[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

Thu Apr 9 02:08:35 PDT 2020

gamesh411 added a comment.

In D75665#1907938 <https://reviews.llvm.org/D75665#1907938>, @martong wrote:

> > As the CTUDir string prefix is only needed in case of the old approach, I have refactored the external definition mapping storage to NOT include that.
>
> Both `ctu-main.c` and `ctu-on-demand-parsing.c` use the `-analyzer-config ctu-dir=%t/ctudir2` setting. So it is not clear for me why we don't need the prefix. I believe we still need that directory setting otherwise where could we find the externalDefMap file?

You are right, the ctudir2 prefix is not needed as the %t substitution is test-file-level unique.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75665/new/

https://reviews.llvm.org/D75665