[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

Kan Shengchen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 8 20:30:15 PDT 2020


skan added a comment.

In D77728#1970922 <https://reviews.llvm.org/D77728#1970922>, @MaskRay wrote:

> In D77728#1970912 <https://reviews.llvm.org/D77728#1970912>, @skan wrote:
>
> > In D77728#1969788 <https://reviews.llvm.org/D77728#1969788>, @MaskRay wrote:
> >
> > > > Make -malign-branch-prefix-size an alias for -mpad-max-prefix-size (For GCC compatibility)
> > >
> > > I cannot find a discussion on -mpad-max-prefix-size. Is it a planned GNU as option or GCC driver option?
> >
> >
> > `-mpad-max-prefix-size` has nothing to do with GCC,  it exposes the `-x86-pad-max-prefix-size` to clang
>
>
> Then it is incorrect to say `HelpText<"Alias for -mpad-max-prefix-size">;// Alias for GCC compatibility`


Fine, we can have more discussion on this revision. D77628 <https://reviews.llvm.org/D77628> really has nothing to do with GCC/GAS compatibility, could you remove the "request change"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77728/new/

https://reviews.llvm.org/D77728





More information about the cfe-commits mailing list