[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert accepted this revision.
jdoerfert added a subscriber: atmnpatel.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117
+    if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown &&
+        (DSAStack->getDefaultDSA() != DSA_none || DVarTop.CKind == OMPC_shared))
+      return nullptr;
----------------
ABataev wrote:
> jdoerfert wrote:
> > Does `DSAStack->getDefaultDSA() != DSA_none` work once we have `(first)private` default kinds or do we need to check for shared explicitly?
> An extra check for `!= DSA_firstprivate` will be required.
OK. Needs to be part of D75591. @atmnpatel  Can you include this in your patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77731/new/

https://reviews.llvm.org/D77731