[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.

Apologies for my delay.

LGTM. Wait for @lebedev.ri though.



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/openmp-use-default-none.rst:56
+  // ``parallel`` directive can have ``default`` clause, and said clause is
+  // specified, but with ``shared`` kind, which is not ``none``, diagnose.
+  void p0_3() {
----------------
Nit: -`shared` +`firstprivate`


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:12576
+  }
+
   if (Kind == OMP_DEFAULT_none)
----------------
@lebedev.ri This should address your issue, correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75591/new/

https://reviews.llvm.org/D75591