[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert updated this revision to Diff 256108.
jdoerfert added a comment.

Use @lattern 's wording which is more specific and has less spelling errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77683/new/

https://reviews.llvm.org/D77683

Files:
  llvm/docs/CodeReview.rst


Index: llvm/docs/CodeReview.rst
===================================================================
--- llvm/docs/CodeReview.rst
+++ llvm/docs/CodeReview.rst
@@ -29,8 +29,9 @@
 significant patches to be reviewed before being committed. Smaller patches
 (or patches where the developer owns the component) that meet
 likely-community-consensus requirements (as apply to all patch approvals) can
-be committed prior to an explicit review. In situations where there is any
-uncertainty, a patch should be reviewed prior to being committed.
+be committed prior to an explicit review. If there is likely to be uncertainty,
+you should default to getting a patch reviewed prior to commit, particularly if
+someone has asked for extra review of a specific area.
 
 Please note that the developer responsible for a patch is also
 responsible for making all necessary review-related changes, including


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77683.256108.patch
Type: text/x-patch
Size: 893 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200408/bf6b9a2e/attachment-0001.bin>