[clang] 937e63b - [X86] Fix x86-header-warnings.c test not detecting regressions as intended.

Pierre Gousseau via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 8 07:24:29 PDT 2020


Author: Pierre Gousseau
Date: 2020-04-08T15:22:44+01:00
New Revision: 937e63b8d5e961c2a7da25558bbcdd5388182b67

URL: https://github.com/llvm/llvm-project/commit/937e63b8d5e961c2a7da25558bbcdd5388182b67
DIFF: https://github.com/llvm/llvm-project/commit/937e63b8d5e961c2a7da25558bbcdd5388182b67.diff

LOG: [X86] Fix x86-header-warnings.c test not detecting regressions as intended.

Use -verify -fsyntax-only and expected-no-diagnostics as
recommended by Paul.

Reviewed By: probinson

Differential Revision: https://reviews.llvm.org/D77393

Added: 
    

Modified: 
    clang/test/Headers/x86-header-warnings.c

Removed: 
    


################################################################################
diff  --git a/clang/test/Headers/x86-header-warnings.c b/clang/test/Headers/x86-header-warnings.c
index ec7cfc6adaad..3306b95c1b48 100644
--- a/clang/test/Headers/x86-header-warnings.c
+++ b/clang/test/Headers/x86-header-warnings.c
@@ -1,16 +1,14 @@
 // Fix sign conversion warnings found by fsanitize=implicit-integer-sign-change
 // in intrinsic headers.
 // Preprocess file to workaround no warnings in system headers.
-// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E 2>&1 \
-// RUN:     | %clang_cc1 -x c - -triple x86_64-pc-linux-gnu -ffreestanding -Wsign-conversion -E -o - 2>&1 \
-// RUN:     | FileCheck --allow-empty %s
+// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E -CC 2>&1 \
+// RUN:     | %clang_cc1 -x c - -triple x86_64-pc-linux-gnu -Wsign-conversion -fsyntax-only -verify
 // REQUIRES: x86-registered-target
 
 #include <x86intrin.h>
 
 void test0() {
-  // CHECK-LABEL: test0
-  // CHECK-NOT: warning:
+  // expected-no-diagnostics
   _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON);
   _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_OFF);
   _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_MASK);


        


More information about the cfe-commits mailing list