[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 8 07:34:24 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from the file names concern.



================
Comment at: clang-tools-extra/clang-tidy/objc/CMakeLists.txt:8
   MissingHashCheck.cpp
+  NsinvocationArgumentLifetimeCheck.cpp
   ObjCTidyModule.cpp
----------------
I think the files should be renamed to `NSInvocationArgumentLifetimeCheck` based on typical naming conventions for NS identifiers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77571/new/

https://reviews.llvm.org/D77571





More information about the cfe-commits mailing list