[PATCH] D77385: [clangd] Add index export to dexp

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:322
+  // Make Export command option(s) available on command line.
+  // That allows for convenient (piping/redirecting) a dump non-interactively
+  // without passing through REPL.
----------------
sammccall wrote:
> I wonder if we should generalize this instead to running an arbitrary command non-interactively: `dexp -c "dump"`
> 
> No need to do that in this patch but maybe leave a TODO
Done in 49268a678c2f0233f71363b0988d4b159496b036 - I think we can drop this and fold ExportImpl and ExportCmd together.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77385/new/

https://reviews.llvm.org/D77385