[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 7 18:32:40 PDT 2020


mehdi_amini added a comment.

This seems like both over-fitting the general rule for a specific case and fuzzy/imprecise enough that it isn't clear to me how much useful it is in practice?

Maybe we could step back: what is the concrete problem that this intends to address? Is there an area where it has been problematic at the moment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77683/new/

https://reviews.llvm.org/D77683





More information about the cfe-commits mailing list