[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 7 18:32:39 PDT 2020


dexonsmith added a comment.

This is thanks to a commit of mine that shaved a word off of `SmallVector`.  Some options to consider:

1. Revert to word-size integers (`size_t`? `uintptr_t`?) for Size and Capacity for small-enough types.  Could be just if `sizeof(T)==1`.  Or maybe just for `char` and `unsigned char`.
2. Revert my patch entirely and go back to words (these used to be `void*`).
3. (Your patch, stop using `SmallVector<char>`.)

I think I would prefer some variation of (1) over (3).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77621/new/

https://reviews.llvm.org/D77621





More information about the cfe-commits mailing list