[PATCH] D77085: [clang-tidy] Added support for validating configuration options

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 7 11:23:20 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a few minor nits.



================
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:117
+  llvm::Expected<bool> ValueOr = get<bool>(LocalName);
+  if (ValueOr) {
+    return *ValueOr;
----------------
Elide braces


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:144
+  llvm::Expected<bool> ValueOr = getLocalOrGlobal<bool>(LocalName);
+  if (ValueOr) {
+    return *ValueOr;
----------------
Elide braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77085/new/

https://reviews.llvm.org/D77085





More information about the cfe-commits mailing list