[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

[Mike Rice via Phabricator via cfe-commits]

mikerice added a comment.

My reasoning is that the generic TreeTransform does semantic analysis on CallExpr and this seems to be related semantic analysis that would need to be redone when the call changed as well.  Say someone codes up a new subclass of TreeTransform that maybe changes one of the arguments.  If ActOnOpenMPCall is not called does that create a broken AST?

So it is not clear to me that only template instantiation wants it.  I don't claim to be an expert on this code but if I subclassed TreeTransform I wouldn't expect to have to rewrite this OpenMP code each time I modified the base call expression.  We could probably use more opinions on this in any case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77290/new/

https://reviews.llvm.org/D77290