[PATCH] D77419: [libTooling] Simplify the representation of Transformer's RewriteRules.

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:40
+
+/// A map from a match result to a list of concrete errors (with possible
+/// failure). This type is a building block of rewrite rules, but users will
----------------
"A map"? it is a function.

Maybe "Maps a match result to..."

Also, "concrete errors" probably should be "concrete edits".


================
Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:44
+/// of `EditList`.
+using EditList = MatchConsumer<llvm::SmallVector<Edit, 1>>;
+
----------------
Could you explain the idea behind the word "list" in the name? I don't get it.

Maybe "EditGenerator"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77419/new/

https://reviews.llvm.org/D77419