[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 6 14:12:13 PDT 2020
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good (with the comment suitably tweaked). Thanks!
================
Comment at: clang/lib/CodeGen/CGExpr.cpp:4334
incrementProfileCounter(expr);
+ // If a throw expression we need to return dead as lvalue.
+ if (auto *ThrowExpr = dyn_cast<CXXThrowExpr>(live->IgnoreParens())) {
----------------
Comment doesn't match the code any more.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77502/new/
https://reviews.llvm.org/D77502
More information about the cfe-commits
mailing list