[PATCH] D73307: Unique Names for Functions with Internal Linkage

Mon Apr 6 13:37:46 PDT 2020

rnk added a comment.

Sorry for the delay, thanks for the update. Code looks good, but I want the documentation to be specific.

================
Comment at: clang/docs/UsersManual.rst:1684
+   linkage symbols. The unique name is obtained by appending the hash of the
+   full module name to the original symbol. This option is particularly useful
+   in attributing profile information to the correct function when multiple
----------------
I think it's important to be specific here. I'd go so far as to say:
"When this option is set, compiler hashes the main source file path from the command line and appends it to all internal symbols. If a program contains multiple objects compiled from the same source file path, the symbols are not guaranteed to be unique."

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73307/new/

https://reviews.llvm.org/D73307