[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2
+// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \
+// RUN:   -analyzer-store=region -verify %s
+
----------------
vsavchenko wrote:
> Szelethus wrote:
> > NoQ wrote:
> > > `-analyzer-store=region` is redundant; it's the default and the only possible value for this option. We should remove it from other tests as well.
> > The default lit command is a bit silly. What does `-setup-analyzer` or something like that even do?
> Should I remove it from here in this commit or we should clean up all tests at once?
> The default lit command is a bit silly. What does `-setup-analyzer` or something like that even do?

```lang=c
  1029   if (PPOpts.SetUpStaticAnalyzer)
  1030     Builder.defineMacro("__clang_analyzer__");
```

:)

> Should I remove it from here in this commit or we should clean up all tests at once?
I'll remove when committing, thx!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77551/new/

https://reviews.llvm.org/D77551