[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Mariya Podchishchaeva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 10:18:54 PDT 2020


Fznamznon added a comment.
Herald added a subscriber: yaxunl.

In D74387#1950593 <https://reviews.llvm.org/D74387#1950593>, @jdoerfert wrote:

> This is needed for OpenMP as well. Does it make sense to include it in this patch or in another one?


I thought OpenMP already has diagnostics for unsupported types (at least looking into this commit https://github.com/llvm/llvm-project/commit/123ad1969171d0b22d0c5d0ec23468586c4d8fa7). Am I wrong?
The diagnostic which I'm implementing here is stricter than existing OpenMP diagnostic, the main goal is do not emit unsupported type at all. Does OpenMP need such restriction as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74387/new/

https://reviews.llvm.org/D74387





More information about the cfe-commits mailing list