[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 10:18:49 PDT 2020


njames93 added inline comments.


================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:16-17
+    if (Item.equals_lower(Search)) {
+      if (Item.equals(Search))
+        return Item.str();
+      MaxEditDistance = 1;
----------------
aaron.ballman wrote:
> Is this case possible to hit? I would imagine that if the search time matches anything in the allowed list, we would have not needed to call `getBestGuess()` in the first place?
This one shouldn't be, I put an assert in for sanity though. The one below with the prefix can be hit though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77499/new/

https://reviews.llvm.org/D77499





More information about the cfe-commits mailing list