[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 09:44:49 PDT 2020


rjmccall added a comment.

I would guess that some visitor still has a `VisitCompoundAssignOperator` implementation, and that the behavior of `VisitBinAssign` happens to do what's needed for it.

You basically have two options:

- Keep a `VisitCompoundAssignOperator` around in `StmtVisitor` for all the compound-assignment operators to delegate to.  You'll have to implement its delegation to `VisitBinaryOperator` manually.
- Search the source base for any remaining implementations of `VisitCompoundAssignOperator` and fold them into `VisitBinaryOperator`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76384/new/

https://reviews.llvm.org/D76384





More information about the cfe-commits mailing list