[PATCH] D77028: Speed up deferred diagnostic emitter

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 08:38:45 PDT 2020


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Thank you.  Minor request, but feel free to commit with that change.



================
Comment at: clang/lib/Sema/Sema.cpp:1558
+    // visited before.
+    if (Done.count(FD))
+      return;
----------------
`insert` returns whether it changed the set, so you can combine this check with the insertion unless the exact ordering is important.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77028/new/

https://reviews.llvm.org/D77028





More information about the cfe-commits mailing list