[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

Marcel Hlopko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 07:33:08 PDT 2020


hlopko marked an inline comment as done.
hlopko added a comment.

Adressing comments.



================
Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264
+  auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front());
+  unsigned SpelledFrontI = &Spelled.front() - File.SpelledTokens.data();
+  unsigned ExpandedBegin;
----------------
gribozavr2 wrote:
> Or assert that SpelledFrontI is less than File.SpelledTokens.size().
I think the assert I added is good enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77209/new/

https://reviews.llvm.org/D77209





More information about the cfe-commits mailing list