[clang-tools-extra] 9e1af17 - [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee

[Roman Lebedev via cfe-commits]

On Mon, Apr 6, 2020 at 5:23 PM Johannes Doerfert <johannes at jdoerfert.de> wrote:
>
> On 4/6/20 9:06 AM, Roman Lebedev wrote:
>
> This seems suspicious.
>
>
> Agreed, especially since this is also not the only place.
>
> I was hoping to unblock the builders with this.
>
>
> Does clang-reorder-fields actually explicitly needs something from
> FrontendOpenMP?
> If not, it looks like there dependency is missing elsewhere, or
> there's wrong layering.
>
> The root cause is the use of `isAllowedClauseForDirective` in ASTMatchers.h.
What is the target encompases that include?
I'd guess that is the one that is missing this dep.

> On Mon, Apr 6, 2020 at 5:03 PM Johannes Doerfert via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>
> Author: Johannes Doerfert
> Date: 2020-04-06T09:01:43-05:00
> New Revision: 9e1af172eec9a06bffac337057a2452b88466288
>
> URL: https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288
> DIFF: https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288.diff
>
> LOG: [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee
>
> Added:
>
>
> Modified:
>     clang-tools-extra/clang-reorder-fields/CMakeLists.txt
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/clang-tools-extra/clang-reorder-fields/CMakeLists.txt b/clang-tools-extra/clang-reorder-fields/CMakeLists.txt
> index 9c75d785cc9a..c357d0a3cfbf 100644
> --- a/clang-tools-extra/clang-reorder-fields/CMakeLists.txt
> +++ b/clang-tools-extra/clang-reorder-fields/CMakeLists.txt
> @@ -1,4 +1,7 @@
> -set(LLVM_LINK_COMPONENTS support)
> +set(LLVM_LINK_COMPONENTS
> +  FrontendOpenMP
> +  support
> +)
>
>  add_clang_library(clangReorderFields
>    ReorderFieldsAction.cpp
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits