[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

In D77184#1961495 <https://reviews.llvm.org/D77184#1961495>, @thakis wrote:

> In D77184#1961220 <https://reviews.llvm.org/D77184#1961220>, @rsmith wrote:
>
> > In D77184#1961214 <https://reviews.llvm.org/D77184#1961214>, @rsmith wrote:
> >
> > > In D77184#1961208 <https://reviews.llvm.org/D77184#1961208>, @rsmith wrote:
> > >
> > > > This has broken my ability to run the `check-clang` target on Linux. There are symlinks in the path from which I run my builds, and this patch is computing incorrect relative paths in that situation.
> > >
> > >
> > > This patch appears to fix the problem:
> >
> >
> > Turns out that's only a partial fix (it fixes `ninja clang-check` but not the general problem). Running `lit` from inside the source directory is still broken. Eg, this used to work:
> >
> >   clang/test$ $BUILDDIR/bin/llvm-lit SemaCXX/constant-expression.cpp
> >
> >
> > ... and doesn't work any more because the relative paths in `lit.site.cfg.py` don't seem to resolve to the right places. Please can you fix or revert?
>
>
> Can you describe your symlink setup in enough detail that I can recreate it locally please?


Two directories $s and $d within $HOME.

Source git checkout in $s
Build dir is $d/build
Symlink $d/src -> $s
Symlink $s/clang/build -> $d/build
Symlink $c -> $s/clang

Configured from $d/build with `cmake ../src`
Actual build is run from $c/build
Manual `lit` commands are run from $c/test

I can provide you with the scripts I use to create my checkouts, symlinks, and to run cmake if you like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77184/new/

https://reviews.llvm.org/D77184