[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 4 00:19:42 PDT 2020


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
sammccall added a comment.

Some saturday morning procrastination.

But I'm wondering how good an idea this is for plaintext: "Returns 'foo' on failure" is better than "Returns foo on failure", right? (With backticks instead of single quotes, phab is eating my formatting)
Maybe we should have an Emphasis flag or something on plaintext to preserve the quotes? (We don't want to include them e.g. in the return type chunks)

Also, realized our model for whitespace around paragraph chunks isn't ideal after all :-(


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77456

Files:
  clang-tools-extra/clangd/FormattedString.cpp
  clang-tools-extra/clangd/FormattedString.h
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77456.255010.patch
Type: text/x-patch
Size: 6814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200404/d4f7388b/attachment-0001.bin>


More information about the cfe-commits mailing list