[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

Fri Apr 3 11:53:39 PDT 2020

leonardchan added a comment.

In D66490#1958747 <https://reviews.llvm.org/D66490#1958747>, @aeubanks wrote:

> In D66490#1638708 <https://reviews.llvm.org/D66490#1638708>, @hfinkel wrote:
>
> > In D66490#1638162 <https://reviews.llvm.org/D66490#1638162>, @rupprecht wrote:
> >
> > > We already know that we don't want this enabled for tsan builds due to https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone else will hit it (it's only when building one particular library).
> >
> >
> > Under the circumstances, that seems like one particular library too many. PR42877 looks like a generic bug, so if we're hitting it here, I see no reason to suspect that others would not hit it elsewhere.
>
>
> https://bugs.llvm.org/show_bug.cgi?id=42877 is marked fixed, any update on this? LLVM 10.0.0 has branched.

It seems that we can go ahead with this patch if there's no other objections. I reran a `ninja check-clang` with this patch and all tests seem to pass (at least when running on x64-linux).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490