[PATCH] D77408: [clang] Annotate trivial getters and setters on hover.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 11:53:38 PDT 2020


sammccall marked 2 inline comments as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/Hover.cpp:376
+llvm::Optional<StringRef> fieldName(const Expr *E) {
+  const auto *ReturnedMember = llvm::dyn_cast<MemberExpr>(E->IgnoreCasts());
+  const auto *Field =
----------------
kadircet wrote:
> if(!ReturnedMember) return None
Oops, also forgot to check the base of the MemberExpr was CXXThisExpr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77408/new/

https://reviews.llvm.org/D77408





More information about the cfe-commits mailing list