[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet marked an inline comment as done.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!



================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:69
             struct Foo {
-              int [[b^ar]];
+              char [[b^ar]];
             };
----------------
sammccall wrote:
> kadircet wrote:
> > any reason for changing these from int to char ?
> hardcoding sizeof(int) isn't portable unless we want to set the target explicitly
right, the test already sets the target though.

I suppose relying less on it is better, so feel free to keep it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77355/new/

https://reviews.llvm.org/D77355