[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

[Sam McCall via Phabricator via cfe-commits]

sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:3236
   QualType ElementType;
+  unsigned NumElements;
 
----------------
fhahn wrote:
> I think you could keep NumElements in VectorTypeBitfields (just remove the bit specifier), as the size of those bitfields can be up to 8 bytes (see the static asserts around line 1775). That should be fine as long as NumTypeBits + 3 <= 32.
Ah, you're right. I just assumed it was taking all the rest of the bits, but there are another 4 bytes free :-\
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77335/new/

https://reviews.llvm.org/D77335