[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 04:16:06 PDT 2020


MyDeveloperDay added a comment.

In D33029#1951346 <https://reviews.llvm.org/D33029#1951346>, @bbassi wrote:

> @MyDeveloperDay Can you please share your thoughts on my comment above?


I'm tempted to agree that perhaps having  as an enumeration `BreakBeforeClosingBracket` with various options might give us greater control

its recently also come to my attention that perhaps we should NEVER use a boolean as an option, as nearly every option that started out as a boolean ended up either needing to add another additional new option or being changed from a boolean to an enumeration later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33029/new/

https://reviews.llvm.org/D33029





More information about the cfe-commits mailing list