[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 03:11:49 PDT 2020


fhahn added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:3236
   QualType ElementType;
+  unsigned NumElements;
 
----------------
I think you could keep NumElements in VectorTypeBitfields (just remove the bit specifier), as the size of those bitfields can be up to 8 bytes (see the static asserts around line 1775). That should be fine as long as NumTypeBits + 3 <= 32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77335/new/

https://reviews.llvm.org/D77335





More information about the cfe-commits mailing list