[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

[Carlos Alberto Enciso via Phabricator via cfe-commits]

CarlosAlbertoEnciso added a comment.

In D77184#1957632 <https://reviews.llvm.org/D77184#1957632>, @thakis wrote:

> Thanks!


Hi,

After the series of changes you have done, I am experiencing a build error on Windows. These are some of the errors:




- Attribute ignored -- Loadable modules not supported on this platform.

Traceback (most recent call last):

  File "<string>", line 1, in <module>
  File "<string>", line 1, in <genexpr>
  File "C:\ProgramData\Python27\lib\ntpath.py", line 529, in relpath
    % (path_prefix, start_prefix))

ValueError: path is on drive X:, start on drive E:
CMake Error at X:/llvm-root/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1508 (message):

  PATHS lengths got confused

Call Stack (most recent call first):

  X:/llvm-root/llvm-project/clang/test/CMakeLists.txt:33 (configure_lit_site_cfg)

CMake Error at X:/llvm-root/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1517 (list):

  list GET given empty list

Call Stack (most recent call first):

  X:/llvm-root/llvm-project/clang/test/CMakeLists.txt:33 (configure_lit_site_cfg)

CMake Error at X:/llvm-root/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1517 (list):

  list GET given empty list

Call Stack (most recent call first):

  X:/llvm-root/llvm-project/clang/test/CMakeLists.txt:33 (configure_lit_site_cfg)

CMake Error at X:/llvm-root/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1517 (list):

  list GET given empty list

Call Stack (most recent call first):

  X:/llvm-root/llvm-project/clang/test/CMakeLists.txt:33 (configure_lit_site_cfg)

CMake Error at X:/llvm-root/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1517 (list):

  list GET given empty list

Call Stack (most recent call first):

  X:/llvm-root/llvm-project/clang/test/CMakeLists.txt:33 (configure_lit_site_cfg)




My CMake command line is:

E:\llvm-root\builds\win\debug\x64>cmake -G"Visual Studio 15 2017 Win64" -Thost=x64 -DCMAKE_BUILD_TYPE=Debug -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-pc-linux-gnu
-DLLVM_ENABLE_PROJECTS="clang" x:\llvm-root\llvm-project\llvm -DLLVM_ENABLE_ZLIB=OFF

Drive E: contains the build files
Drive X: contains the llvm sources




The only way to have a successful build is to revert : ab11b9eefa16661017c2c7b3b34c46b069f43fb7 <https://reviews.llvm.org/rGab11b9eefa16661017c2c7b3b34c46b069f43fb7>




Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77184/new/

https://reviews.llvm.org/D77184