[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.
Jakub Kuderski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 2 20:04:33 PDT 2020
kuhar added inline comments.
================
Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:186
+ for (auto &Pair : children<GraphDiffBBPair>(GDNodePair)) {
+ const NodePtr Succ = Pair.second;
const auto SIT = NodeToInfo.find(Succ);
----------------
kuhar wrote:
> Could this new code be a hoisted into a helper function?
Or alternatively, could the old `ChildrenGetter` be implemented with these 5 magic lines?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77341/new/
https://reviews.llvm.org/D77341
More information about the cfe-commits
mailing list