[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

Alina Sbirlea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 2 16:17:52 PDT 2020


asbirlea added a comment.

I sent this out to get some general feedback, but I'd like to be able to simplify the fact that this is replacing a `for` over `ChildrenGetter` with a `for` over `children<type>(pair)`, plus 5 lines to set up the type and pair; one simplification is around getting the type inside `children` (`GraphDiffBBPair`) and another around having the BUI or not; for the latter I'm considering updating a few places such that BUI is never nullptr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77341/new/

https://reviews.llvm.org/D77341





More information about the cfe-commits mailing list