[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 2 13:33:55 PDT 2020


sammccall added a comment.

In D77313#1957690 <https://reviews.llvm.org/D77313#1957690>, @efriedma wrote:

> I think I would rather just pay the extra 8 bytes per VectorType, and expand this to support all vector types supported by LLVM.  It's not like we allocate enough VectorTypes for it to matter, anyway.


llvm::VectorType seems to accept arbitrary `unsigned` size, so IIUC you'd suggest putting just putting `unsigned NumElements` in `VectorType`, which would cost 4 bytes and another 4 in padding. 
Sounds reasonable to me, I'll try that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77313/new/

https://reviews.llvm.org/D77313





More information about the cfe-commits mailing list