[PATCH] D77240: [CUDA] Add missing cmath overloads
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 2 09:44:21 PDT 2020
tra added a comment.
In D77240#1957386 <https://reviews.llvm.org/D77240#1957386>, @jdoerfert wrote:
> I just noticed those as well. I forgot to put the new definitions into the forward declare header. Will do it in a second. The OpenMP math overlay doesn't have one so I forgot :(
I'm not sure how it's going to help. The problem is that the functions are already defined by CUDA headers. Moving the duplicate definition to a different header does not change that.
Bottom line is that the already-existing definitions are not needed for CUDA. If OpenMP needs them, then they should probably go into an OpenMP-specific header.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77240/new/
https://reviews.llvm.org/D77240
More information about the cfe-commits
mailing list