[PATCH] D77240: [CUDA] Add missing cmath overloads

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 1 15:12:17 PDT 2020


jdoerfert added a comment.

In D77240#1955755 <https://reviews.llvm.org/D77240#1955755>, @tra wrote:

> In D77240#1955724 <https://reviews.llvm.org/D77240#1955724>, @jdoerfert wrote:
>
> > At least that one is defined in what is "now" `__clang_cuda_math.h`:
>
>
> Cool. We may be OK, but we still need to verify it. Math headers are rather fragile and we need to make sure it all still works two different standard libraries and all CUDA versions. 
>  Unfortunately my CUDA build bot has decided to die the day we've started working from home, so it has to be done manually.
>  Let me try patching in your changes and try them with the CUDA versions I have. Stay tuned.


Thank you very much! I (now) know what pain math headers are... These are almost the last infrastructure changes I need, there is a problem with the include path order on some system but for that I first need to write a patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77240/new/

https://reviews.llvm.org/D77240





More information about the cfe-commits mailing list