[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

Todd Snider via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 1 14:38:26 PDT 2020


snidertm added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:3588
+                      NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask),
       RegParmOffset = 8
     }; // Assumed to be the last field
----------------
Shouldn't RegParmOffset be updated to 9, I believe it is used to shift the regParm value so that it encoded in the bits above CmseNSCallMask


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71129/new/

https://reviews.llvm.org/D71129





More information about the cfe-commits mailing list