[PATCH] D77239: [CUDA][NFCI] Use unqualified lookup for math functions

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 1 14:38:24 PDT 2020


tra added a subscriber: jlebar.
tra added a comment.

> The other macro uses a unqualified lookup already and the qualified one
>  will cause problems in the OpenMP overlay.

There's a bit of inconsitency here.  While `__CUDA_CLANG_FN_INTEGER_OVERLOAD_2` indeed uses unqualified lookup, pretty much all other functions use qualified global scope lookups, which, I believe is correct, as we want to use the functions defined by CUDA headers there.

@jlebar -- WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77239/new/

https://reviews.llvm.org/D77239





More information about the cfe-commits mailing list