[PATCH] D77168: Add a flag to debug automatic variable initialization

[Jian Cai via Phabricator via cfe-commits]

jcai19 added a comment.

In D77168#1955312 <https://reviews.llvm.org/D77168#1955312>, @jfb wrote:

> Do you not think `pragma` is a more general approach? That's what's used in a bunch of other cases, and I'd like to see it attempted here.


Yes I absolutely agree pragma is a great way to bisect and will work in many scenarios, and the result is clear once the bisection is done. But like @srhines said, doing this one function at a time is preferable but not always possible (or maybe we can wrap consecutive functions within the same pragma push/pop pair? I tried to verify but ran into error: attribute 'uninitialized' is not supported by '#pragma clang attribute), and automating it is more difficult. From this perspective, I think the proposed patch is complementary to pragma and not meant to replace it.

> If not, I agree with John that just counting up isn't a good bisection experience. I'd rather see a begin / end bound.

Thank you for the feedback! I will start looking into it.

> You're also missing the auto-init in `initializeAlloca`.

Thanks I will address this in next patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77168/new/

https://reviews.llvm.org/D77168