[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

Wed Apr 1 05:30:58 PDT 2020

aschwaighofer marked an inline comment as done.
aschwaighofer added inline comments.

================
Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217
+  /// ProtocolPtrTy.
+  virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0;
+
----------------
rjmccall wrote:
> aschwaighofer wrote:
> > aschwaighofer wrote:
> > > rjmccall wrote:
> > > > Can this name more closely parallel the "external" name, like `getOrEmitProtocolObject`?
> > > > 
> > > > Also, I think we're incrementally lowercasing new method names.
> > > This is an already existing method. I just moved it higher in the class hierarchy to CGObjCRuntime from CGObjCMac so that it is callable from getOrEmitProtocolObject.
> > s/getOrEmitProtocolObject/emitObjCProtocolObject
> I see.  Well, in that case, I won't ask you to rename it, but please do implement it for the GNU runtime as I mentioned.
Done. I introduced 
`CGObjCGNU::GenerateProtocolRef(const ObjCProtocolDecl *PD)` because it only existed in the `CGObjCGNUstep2` subclass.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77077/new/

https://reviews.llvm.org/D77077