[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

oh wow! thanks for looking into this.

Looking at the history,  it seems like an oversight. The patch that introduced packexpansion bit: https://github.com/llvm/llvm-project/commit/44c247f0f009eec70a193335c8a353d6f8602bfd.

it didn't add that field to pchattr serialization code unfortunately. (another example on isimplicit, which adds attr to record https://github.com/llvm/llvm-project/commit/36a5350e51a6dcfae424332aaa266a1e5bfb8c4f)

Could you add tests though ? Something similar to clang/test/PCH/attrs-PR8406.c should be enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77194/new/

https://reviews.llvm.org/D77194