[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 31 12:33:17 PDT 2020


arsenm added a comment.

In D76862#1953013 <https://reviews.llvm.org/D76862#1953013>, @yaxunl wrote:

> Are there any other clang options affecting flushing denormals? If so, are they working properly after this change? Do we need to have tests for them? Thanks.


I already ensured these are correct for OpenCL, so those already have tests. I didn't realize the HIP toolchain was totally separate, so this fixes it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76862/new/

https://reviews.llvm.org/D76862





More information about the cfe-commits mailing list