[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

Do you have a lit test as well? It would be useful to have one that is similar to the one you mention in the review's summary.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:780
 
+  if (AggressiveEraseModeling) {
+    if (const auto *CData = getContainerData(State, ContReg)) {
----------------
This seems to be very similar to the hunk we have in `handleErase`, so this suggests some unnecessary code duplication. I presume we could create a function which is called from both callers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77150/new/

https://reviews.llvm.org/D77150