[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 31 06:37:15 PDT 2020


sammccall added a comment.

I like the idea, but it seems to regress quite a lot of diagnostics... e.g. where we fail to deduce auto and then say it's not a pointer.

Also this is regressing things in the -fno-recovery-ast case, because of the changes to CheckDeclInExpr with the existing callsites that allow invalid decls. (I'm not sure what passing AcceptInvalid actually *did* before)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76831/new/

https://reviews.llvm.org/D76831





More information about the cfe-commits mailing list