[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

[Tamas Petz via Phabricator via cfe-commits]

tamas.petz created this revision.
tamas.petz added a reviewer: momchil.velikov.
tamas.petz added a project: clang.
Herald added a subscriber: cfe-commits.
danielkiss added a comment.
tamas.petz marked an inline comment as done.

just a nit, LGTM otherwise.



================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:402
 #undef VALUE_CODEGENOPT
-
----------------
is this change necessary? 


================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:402
 #undef VALUE_CODEGENOPT
-
----------------
danielkiss wrote:
> is this change necessary? 
I think there should be one new line at the end of the file, not two.


Reason: the option has an effect on preprocessing.

Also see thread: http://lists.llvm.org/pipermail/cfe-dev/2020-March/065014.html


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77131

Files:
  clang/include/clang/Basic/CodeGenOptions.def
  clang/include/clang/Basic/CodeGenOptions.h
  clang/include/clang/Basic/LangOptions.def
  clang/include/clang/Basic/LangOptions.h
  clang/include/clang/Basic/TargetInfo.h
  clang/lib/Basic/Targets/AArch64.cpp
  clang/lib/CodeGen/CGDeclCXX.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/Frontend/CompilerInvocation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77131.253829.patch
Type: text/x-patch
Size: 12287 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200331/cab13d48/attachment-0001.bin>