[PATCH] D76922: [Syntax] Remove delayed folding from tree building.
Marcel Hlopko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 31 00:31:01 PDT 2020
hlopko added a comment.
I propose adding those tests in a separate patch to keep this one focused. Those tests are currently failing, because:
- we assume initializer, if present, is extending the declarator range, but `struct P {} p;` has initializer ending where declarator ended already.
- UnknownExpressions finds its way inside SimpleDeclarator for p in `struct P {} p, *pp`;
- typedefs also fail, unable to find the end of declarator properly. I didn't investigate further.
Fixing those seems worthy of a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76922/new/
https://reviews.llvm.org/D76922
More information about the cfe-commits
mailing list