[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/CMakeLists.txt:311
+  "SystemZ Default Arch")
+add_definitions( -DCLANG_SYSTEMZ_DEFAULT_ARCH="${CLANG_SYSTEMZ_DEFAULT_ARCH}")
+
----------------
thakis wrote:
> thakis wrote:
> > Hahnfeld wrote:
> > > Passing values like this is unusual for CMake and causes all source files to be recompiled if the value is changed. Instead could we add this to `include/clang/Config/config.h.cmake` like other `CLANG_DEFAULT_*` options?
> > +1
> Also, this is used in one cpp file; passing the define to every compilation unit seems a bit aggressive.
> 
> I'll try to land a patch to fix this.
Done in c506adcdf2ca3ba6459e52e09c55868e3b57af46. (This only changes the implementation of the feature; the way people who build clang tell cmake what they want didn't change.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75914/new/

https://reviews.llvm.org/D75914