[PATCH] D77022: [analyzer] Use IgnoreImpCasts() instead of reimplementing it.
    Nico Weber via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon Mar 30 11:24:24 PDT 2020
    
    
  
thakis marked an inline comment as done.
thakis added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512
+  return E->IgnoreImpCasts();
 }
 
----------------
NoQ wrote:
> Charusso wrote:
> > I think it would make sense to remove the helper-function completely. (Being used 2 times.)
> Yup.
I didn't do that because I liked the comment that this is for the _Nonnull implicit ARC casts – if I inline the function I have to duplicate the comment.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77022/new/
https://reviews.llvm.org/D77022
    
    
More information about the cfe-commits
mailing list