[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Mon Mar 30 10:49:53 PDT 2020

Szelethus added a comment.

In D68165#1949954 <https://reviews.llvm.org/D68165#1949954>, @ldionne wrote:

> > Closed by commit rG703a1b8caf09 <https://reviews.llvm.org/rG703a1b8caf09a5262a45c2179b8131922f71cf25>: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap (authored by ldionne, committed by Szelethus). · Explain Why
>
> This is really strange -- it looks like 703a1b8caf09 <https://reviews.llvm.org/rG703a1b8caf09a5262a45c2179b8131922f71cf25> was attributed to me in git, but I have nothing to do with this change. How did you commit the patch? Is that some Phabricator bug?

Ugh, I squashed my local commits and pushed, it seems like for some reason it made you the author... it has happened to me before (always with you, for some reason), but was able to notice and correct it. There is little we can do about this, right?

In D68165#1950212 <https://reviews.llvm.org/D68165#1950212>, @NoQ wrote:

> Not a phabricator bug. Maybe @Szelethus's local git somehow got in a weird state(?)

Its been a source of endless misery :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68165/new/

https://reviews.llvm.org/D68165