[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:2144
+  bool isErrorType() const {
+    return getDependence() & TypeDependence::Error;
+  }
----------------
Why is this  called `isErrorType` when the expr version is `containsErrors`?


================
Comment at: clang/lib/Parse/ParseExprCXX.cpp:3109
+        QualType PreferredType;
+        if (TypeRep)
+          PreferredType = Actions.ProduceConstructorSignatureHelp(
----------------
Add a comment for what the null case means? (When do we actually hit this?)


================
Comment at: clang/lib/Sema/SemaType.cpp:1591
+    if (Result.isNull() || Result->isErrorType()) {
       Result = Context.IntTy;
       declarator.setInvalidType(true);
----------------
we've added the ability to represent types containing errors, but now we're dropping the type.
Is marking the declarator as invalid sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77037/new/

https://reviews.llvm.org/D77037